chore: bump nightly version used in CI #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires fixing a few warnings.
carllerche
commented
Jan 27, 2020
| // This `extern` is required for older `rustc` versions but newer `rustc` | ||
| // versions warn about the unused `extern crate`. | ||
| #[allow(unused_extern_crates)] |
There was a problem hiding this comment.
I'm not 100% sure if this is the best strategy, but the extern crate proc_macro is required in Rust 1.40 but not on nightly.
There was a problem hiding this comment.
This looks like the most reasonable way around it. For reference, it was changed in cargo in rust-lang/cargo#7700.
jebrosen
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires fixing a few warnings.